-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xref
and yref
to legends
#6589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
reviewed
May 3, 2023
archmoj
reviewed
May 3, 2023
archmoj
reviewed
May 3, 2023
archmoj
reviewed
May 3, 2023
Great PR 🥇 thanks to @hannahker. |
1 task
alexcjohnson
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one more remnant of moving the min/max logic to defaults. 💃
archmoj
reviewed
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add support for container-referenced positioning for plot legends. See demo CodePen here: https://codepen.io/hannahker/pen/wvEZZvN
API changes:
yref
andxref
parameters are added tolayout.legend
.Expected behaviour:
layout.legend.yref
orlayout.legend.xref
are set to'container'
._fullLayout._reservedMargin
accordingly, meaning that legends may be automatically positioned to avoid components such as automargined axes.xref='container'
, then margin space will be added to the_reservedMargin
on the left or the right of a plot area (depending ifx > 0.5
)yref='container'
, then margin space will be added to the_reservedMargin
on the top or bottom of a plot area (depending ify > 0.5
).xref='container'
andyref='container'
, then margin spacing will be added to the top or bottom iforientation='v
' and left or right iforientation='h'
.The defaults for
yanchor
,xanchor
,y
, andx
have also been adjusted for cases where container-referencing is applied.